Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rustdoc on
Backend::latest_finalized_block_refsays "Note: needed only in blocks client for finalized block stream; can prolly be removed." That was copy-pasted onto bothlatest_finalized_block_refandlatest_best_block_refin #1126. #1161 removed the best-block method and left the note on the finalized one, where it has been wrong since:OnlineClient::at_current_blockcalls it on every default read, andCombinedBackendandLegacyBackendcall it too. This removes the sentence; the method's one-line description stays.