Support forking a custom relay chain - #137
Open
mordamax wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #129, and includes #135's change (a custom relay has to be able to supply its endpoint, so the two overlap).
-r custom%<name>%<rpc_endpoint>%<chain_spec_path>forks a relay zombie-bite has no built-in knowledge of. The name is what artifacts are named after, the endpoint is what state and metadata are read from, and the spec is what the node is started with (--chain <spec>instead of a network name). There is no built-in host config for such a relay, soConfiguration::ActiveConfighas to come from the endpoint — the bite fails with that reason if it can't.A relay name outside
polkadot/kusama/paseo/westendis now a custom relay instead of silently falling back to polkadot. That is what lets the helper subcommands (generate-artifacts,clean-up-dir), which only get the name back as a string, keep naming a custom relay's artifacts correctly — and a typo'd name now fails instead of biting the wrong chain.The node stores its db under the chain-spec's own
id, which need not match the artifact name, so the snapshot path is resolved from the spec.Closes #133
Closes #134