fix(viewer): harden WebGPU slab recovery#518
Merged
Merged
Conversation
Co-authored-by: Connor Soohoo <connorsoohoo@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ports the two still-relevant fixes from #464 onto current main and credits Connor Soohoo in the commit. The empty-roof part of #464 is already superseded by the broader export hardening in #466.
Verification
Note
Medium Risk
Touches per-frame WebGPU render error handling and slab GPU geometry attributes; limited scope but affects viewer stability when MRT passes fail.
Overview
Hardens WebGPU rendering for slabs and post-processing recovery paths.
When slab geometry is split into top/side meshes,
splitSlabFacesByFacingnow duplicates primaryuvintouv2on both sub-geometries (same pattern as columns/roofs), so node-material / MRT pipelines don’t hit missinguv2bindings. A regression test assertsuv2matchesuvon both slab meshes frombuildSlabGeometry.If the WebGPU MRT post-processing
render()throws, the viewer callssetRenderTarget(null)before disposing the pipeline and retrying/falling back, so a stuck MRT target doesn’t poison the directrenderer.renderfallback.Reviewed by Cursor Bugbot for commit 30a0249. Bugbot is set up for automated code reviews on this repo. Configure here.