chore(docs): Custom color example should use fewer sections#12559
Open
rebeccaalpert wants to merge 1 commit into
Open
chore(docs): Custom color example should use fewer sections#12559rebeccaalpert wants to merge 1 commit into
rebeccaalpert wants to merge 1 commit into
Conversation
Two blue sections were being used. This caused a problem in high contrast mode since the sections are highlighted. This commit should adjust us down to one section, but allow us to keep the cute pyramid-in-sky effect. Fixes patternfly#12423 Assisted-by: Cursor
WalkthroughThe custom color pie chart example removes a duplicate “Sky” slice, changes its value, and derives ChangesPie chart example
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12559.surge.sh A11y report: https://pf-react-pr-12559-a11y.surge.sh |
thatblindgeye
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two blue sections were being used. This caused a problem in high contrast mode since the sections are highlighted. This commit should adjust us down to one section, but allow us to keep the cute pyramid-in-sky effect.
Example: https://pf-react-pr-12559.surge.sh/components/charts/pie-chart#custom-color-scale
Fixes #12423
Assisted-by: Cursor
Summary by CodeRabbit