Skip to content

fix(a11y): ignore target-size rule to allow WCAG 2.2 bump#12560

Open
kmcfaul wants to merge 1 commit into
patternfly:mainfrom
kmcfaul:a11y-target-size
Open

fix(a11y): ignore target-size rule to allow WCAG 2.2 bump#12560
kmcfaul wants to merge 1 commit into
patternfly:mainfrom
kmcfaul:a11y-target-size

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What: Closes #12296

Temporarily ignoring the target-size rule to allow 2.2 bump to go through. Will re-enable after #12558 is resolved.

Summary by CodeRabbit

  • Tests
    • Updated accessibility checks to exclude the target-size rule from automated crawl results.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0218309b-64fb-4db9-b081-16caf021f1dd

📥 Commits

Reviewing files that changed from the base of the PR and between c9faa23 and 06f1c9e.

📒 Files selected for processing (1)
  • packages/react-docs/patternfly-a11y.config.js

Walkthrough

The PatternFly accessibility crawl configuration now adds the axe target-size rule to its ignored rules.

Changes

Accessibility crawl configuration

Layer / File(s) Summary
Ignore target-size violations
packages/react-docs/patternfly-a11y.config.js
Adds target-size to the exported ignoreRules array.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • #12558 — Directly concerns disabling the target-size axe rule in the accessibility configuration.
  • #8492 — Concerns resolving violations associated with the axe target-size rule.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only ignores a rule and does not identify violation causes or open follow-up issues as required by #12296. Add the violation analysis and create/link follow-up issues for affected components, or update the linked issue scope.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to ignore the target-size a11y rule for the WCAG 2.2 bump.
Out of Scope Changes check ✅ Passed The change is limited to the a11y config tweak described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate work needed for React a11y tool bump violations

3 participants