Ohttp msrv bump 1.85.0 - #9
Merged
Merged
Conversation
benalleng
force-pushed
the
ohttp-msrv-bump-1.85.0
branch
from
September 10, 2026 15:47
7902c81 to
84a89d6
Compare
benalleng
force-pushed
the
ohttp-msrv-bump-1.85.0
branch
2 times, most recently
from
September 22, 2026 14:54
92b2606 to
fc10074
Compare
benalleng
marked this pull request as ready for review
September 22, 2026 14:58
benalleng
force-pushed
the
ohttp-msrv-bump-1.85.0
branch
2 times, most recently
from
September 22, 2026 15:03
14a25db to
225895a
Compare
benalleng
marked this pull request as draft
September 22, 2026 15:12
benalleng
force-pushed
the
ohttp-msrv-bump-1.85.0
branch
2 times, most recently
from
September 22, 2026 15:23
6eb63a7 to
d019b4b
Compare
benalleng
marked this pull request as ready for review
September 22, 2026 15:23
benalleng
force-pushed
the
ohttp-msrv-bump-1.85.0
branch
2 times, most recently
from
September 22, 2026 15:41
73d3290 to
14e1b59
Compare
By updating the editions to 2024 it allows us to utilize the more up-to-date cargo resolver features to keep msrv in check within the toml configuration itself. This change does mandate that we update the msrv to at least 1.84.0 but with rust-payjoin and the main payjoin crate already being at 1.85.0 it seems appropriate to do the same here. rustfmt takes its style edition from the crate edition, so the 2024 edition also brings the 2024 formatting rules, mostly the new import ordering. The reformat lands in this commit because the tree only passes cargo fmt --check once the edition and formatting change together.
with the latest update to our msrv I think it is appropriate to ensure at least at a baseline that the library passes at our msrv.
DanGould
force-pushed
the
ohttp-msrv-bump-1.85.0
branch
from
September 23, 2026 08:31
14e1b59 to
aa6b974
Compare
Member
|
Force pushed because rustfmt takes its style edition from the crate edition so those need to land together if CI is to pass on every commit, which is our aspirational convention elsewhere. Because I'm the last to push, I'm seeking your approval @benalleng |
DanGould
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the msrv to 1.85.0 and also uses more up-to-date cargo toml features to better handle msrv pinning within the repo.
Closes #6
Blocked by #8