Repository navigation
Add CodeQL workflow to satisfy required code-scanning check - #89
Merged
Merged
Conversation
The repo-wide ruleset requires a passing CodeQL code-scanning result before any PR can merge, but no CodeQL workflow existed anywhere in .github/workflows/ — every PR (e.g. #88) was permanently stuck at "Waiting for Code Scanning results" with no way to resolve it. Mirrors ci.yml's push/pull_request-on-all-branches trigger so results attach to PRs against any branch, not just main, plus a weekly schedule scan of the default branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rulesets/14448750) requires a passing CodeQLcode_scanningresult on every PR into every branch, but no CodeQL workflow existed anywhere in.github/workflows/— so that required check could never run or resolve, leaving PRs (e.g. Merge release-v0.7 into main #88) permanentlyBLOCKEDat "Waiting for Code Scanning results.".github/workflows/codeql.yml, analyzing Python withgithub/codeql-action. Mirrorsci.yml'spush/pull_requeston all branches (["**"]) so results attach to PRs against any branch, not justmain, plus a weekly scheduled scan of the default branch.Note
This only takes effect for branches that pick up this workflow file (merged into, or rebased on top of, this change). It won't retroactively run on already-open PRs whose head branch predates this file (e.g. #88, #79) unless those branches also merge/rebase this in.
Test plan
python -c "import yaml; yaml.safe_load(...)")ci.ymltrigger patternAnalyze (python)check appears and passes on this PR once Actions runs it