fix: delete endpoint bugs + add comments - #1123
Merged
Merged
Conversation
ale23yfm
approved these changes
Jul 28, 2026
- Count query now uses GET (Solr rejects POST with empty body) - Added getJson() helper for GET requests to Solr - Removed dead $countPayload code - Added solrEscape() reusable function - Check Solr response status after delete - Added step-by-step comments throughout
sebiboga
force-pushed
the
fix/delete-null-payload
branch
from
July 28, 2026 09:10
5afc5f2 to
d7b79b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple bugs in /v1/scraper/jobs/delete/ (merged empty in #1120):
Bug fixes:
postJson()with null/empty body → Solr rejects POST with empty body to /select. Changed togetJson()(GET with URL params)$countPayloadcode (built but never used)Improvements:
getJson()helper for GET requests (matches pattern in jobs/index.php)solrEscape()as reusable function (was inline)