fix: reject oid columns as unsupported

[vyruss]

oid mapped to BIGINT, but pg_duckdb rejects the oid column reference at
plan time in any Iceberg-backed query (the same limit as inet/cidr), so an
oid column archived fine yet became unreadable through the tiered view after
cutover. It's now rejected at provisioning in both the archiver and the
extension, with guidance to store oid values as bigint.

Closes #51.

[coderabbitai]

📝 Walkthrough

Walkthrough

The archiver and ColdFront Iceberg type mappings now reject PostgreSQL oid alongside inet and cidr. Tests, journey validation, and documentation were updated, including guidance to store oid as bigint.

Changes

oid support removal

Layer / File(s)	Summary
Archiver type rejection cmd/archiver/main.go, cmd/archiver/main_test.go	Removes the oid to BIGINT mapping, updates the unsupported-type error, and expects inet, cidr, and oid to fail type conversion.
ColdFront storage rejection extension/coldfront/coldfront--1.0.sql	Removes the oid storage mapping and updates Iceberg unsupported-type handling and related comments.
Validation and documentation ci/journey.sh, docs/architecture_decoupled.md, docs/usage.md	Adds an oid provisioning rejection check, removes oid from supported-type lists, adds char(N), and documents alternative storage types.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The docs change also adds char(N) to the supported-type list, which is unrelated to the oid rejection work.	Remove the unrelated char(N) documentation update or split it into a separate PR unless it is required for this issue.
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: rejecting unsupported oid columns.
Description check	✅ Passed	The description matches the PR's purpose by explaining why oid is now rejected and where guidance changed.
Linked Issues check	✅ Passed	The PR rejects oid before provisioning in archiver and extension and documents bigint storage guidance, matching #51.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/reject-oid-unsupported

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric	Results
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[coderabbitai]

🧹 Nitpick comments (1)

cmd/archiver/main_test.go (1)

179-185: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover the archiver remediation text.

Lines 179-185 verify rejection but not the new oid guidance. Add an expected substring such as oid values as bigint for this case so the Go error contract remains covered; ci/journey.sh only checks the extension message.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/archiver/main_test.go` around lines 179 - 185, Extend the oid case in the
archiver type-validation tests to assert the remediation text contains the
expected substring “oid values as bigint.” Keep the existing rejection assertion
for inet and cidr unchanged, and ensure the oid error contract validates both
rejection and guidance.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@cmd/archiver/main_test.go`:
- Around line 179-185: Extend the oid case in the archiver type-validation tests
to assert the remediation text contains the expected substring “oid values as
bigint.” Keep the existing rejection assertion for inet and cidr unchanged, and
ensure the oid error contract validates both rejection and guidance.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dd90cb51-e04d-414c-874c-c07c88e57041

📥 Commits

Reviewing files that changed from the base of the PR and between 99c79b6 and 3e8f2a4.

⛔ Files ignored due to path filters (1)

• extension/coldfront/test/expected/ddl_alter_column.out is excluded by !**/*.out

📒 Files selected for processing (6)

• ci/journey.sh
• cmd/archiver/main.go
• cmd/archiver/main_test.go
• docs/architecture_decoupled.md
• docs/usage.md
• extension/coldfront/coldfront--1.0.sql

[vyruss]

@coderabbitai char(n) out-of-scope flag is a false positive: this diff only removes oid from that line. On docstring coverage: this commit adds no new exported functions, so nothing is newly undocumented.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@vyruss You’re right on both points. The char(n) flag was a false positive—the change only removes oid—and no new exported functions were added, so there is no new docstring coverage requirement. I’m withdrawing those findings.