Repository navigation
Enhancing Smoke tests - #403
Merged
Merged
Conversation
... since they change elements that are already attached to an opened space.
This reduces time to settle a space since infinite animation is considered settled already, while 10 loops settle only after the 10 loops are done.
- Implement ToExamplesSmokeTest, a common superclass for smoke tests. - It is a subclass of BlParameterizedHostTest, so buy default only run on headless host (faster than the others) - Rename ToExperimentsMockTest, ToSandBoxMockTest and ToTopLevelMockTest with "Smoke" word, and make them subclasses of ToExamplesSmokeTest - #ignoredExampleSelectors excludes slowerand problematic examples from smoke tests (e.g. URL requests that sometimes fail)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
Commits:
This reduces time to settle a space since infinite animation is considered settled already, while 10 loops settle only after the 10 loops are done.