Repository navigation
fix: replacement of existing NIF files - #109
Merged
Merged
Conversation
Commit 051306b changed metadata.file_name to include .tar.gz, so File.rm/1 targeted the wrong path and its error was ignored. Strip .tar.gz from the removal path and remove the existing library before extracting cached or downloaded artifacts. This prevents crashes when replacing a NIF that is already loaded.
Owner
|
@leandrocp Excellent! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 051306b changed
metadata.file_nameto include the .tar.gz extension soFile.rm/1targeted the wrong path and its error was ignored.The fix is to strip .tar.gz from the file name to remove the actual lib file before extracting cached or downloaded artifacts.
This prevents crashes when replacing a NIF that is already loaded.