Skip to content

Fix the A220 lights on 2.0: read the LVars as int, add the nose landing light and the emergency lights #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m3rlinek01 wants to merge 1 commit into
base: releases/2.0
Choose a base branch
from
Open

Fix the A220 lights on 2.0: read the LVars as int, add the nose landing light and the emergency lights #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 35 additions & 21 deletions src/aircraft/SynapticA220.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import {
/**
* Synaptic Simulations A220 (MSFS)
* SimVars: https://docs.synapticsim.com/pilots/simvars
*
* The docs describe the two-state switches as "Bool", but that describes the
* switch, not how the value arrives here - so the lookups are FeatureType.Int,
* like every other MSFS config in this repo, and the comparisons are loose.
*/
export default class SynapticA220 extends AircraftConfig {
meta: Meta = {
Expand All @@ -22,36 +26,40 @@ export default class SynapticA220 extends AircraftConfig {

features: FeatureAddresses = {
[AircraftFeature.BeaconLights]: {
'A22X Beacon Lights': FeatureType.Bool,
'A22X Beacon Lights': FeatureType.Int,
},
[AircraftFeature.NavigationLights]: {
'A22X Nav Lights': FeatureType.Bool,
'A22X Nav Lights': FeatureType.Int,
},
[AircraftFeature.StrobeLights]: {
'A22X Strobe Lights': FeatureType.Bool,
'A22X Strobe Lights': FeatureType.Int,
},
[AircraftFeature.TaxiLights]: {
'A22X Taxi Lights': FeatureType.Int,
},
[AircraftFeature.LandingLights]: {
'A22X L Landing Lights': FeatureType.Bool,
'A22X R Landing Lights': FeatureType.Bool,
'A22X L Landing Lights': FeatureType.Int,
'A22X R Landing Lights': FeatureType.Int,
'A22X Nose Landing Lights': FeatureType.Int,
},
[AircraftFeature.LogoLights]: {
'A22X Logo Lights': FeatureType.Bool,
'A22X Logo Lights': FeatureType.Int,
},
[AircraftFeature.WingLights]: {
'A22X Wing Insp Lights': FeatureType.Bool,
'A22X Wing Insp Lights': FeatureType.Int,
},
[AircraftFeature.EmergencyLights]: {
'A22X Emergency Lights': FeatureType.Int,
},
[AircraftFeature.Seatbelts]: {
'A22X Seat Belt Lights': FeatureType.Int,
},
[AircraftFeature.ParkingBrakes]: {
'A22X Parking Brake': FeatureType.Bool,
'A22X Parking Brake': FeatureType.Int,
},
[AircraftFeature.Packs]: {
'A22X L Pack Off': FeatureType.Bool,
'A22X R Pack Off': FeatureType.Bool,
'A22X L Pack Off': FeatureType.Int,
'A22X R Pack Off': FeatureType.Int,
},
[AircraftFeature.AntiIce]: {
'A22X L Cowl Anti Ice': FeatureType.Int,
Expand All @@ -62,7 +70,7 @@ export default class SynapticA220 extends AircraftConfig {
'A22X APU Switch': FeatureType.Int,
},
[AircraftFeature.ExternalPower]: {
INI_GPU_AVAIL: FeatureType.Bool,
INI_GPU_AVAIL: FeatureType.Int,
},
}

Expand All @@ -81,32 +89,38 @@ export default class SynapticA220 extends AircraftConfig {
}

beaconLights(value: number): FeatureState {
return value === 1
return value == 1
}

navigationLights(value: number): FeatureState {
return value === 1
return value == 1
}

strobeLights(value: number): FeatureState {
return value === 1
return value == 1
}

// 0 = Off, 1 = Narrow, 2 = Wide
taxiLights(value: number): FeatureState {
return value > 0
}

landingLights(left: number, right: number): FeatureState {
return left === 1 && right === 1
// Three separate switches: left wing, right wing and nose gear
landingLights(left: number, right: number, nose: number): FeatureState {
return left == 1 || right == 1 || nose == 1
}

logoLights(value: number): FeatureState {
return value === 1
return value == 1
}

wingLights(value: number): FeatureState {
return value === 1
return value == 1
}

// 0 = Off, 1 = Arm, 2 = On
emergencyLights(value: number): FeatureState {
return value > 0
}

// 0 = Off, 1 = Auto, 2 = On
Expand All @@ -115,12 +129,12 @@ export default class SynapticA220 extends AircraftConfig {
}

parkingBrakes(value: number): FeatureState {
return value === 1
return value == 1
}

// Vars report the pack switch as *off*, so a pack is on when its flag is 0
packs(left_off: number, right_off: number): FeatureState {
return left_off === 0 || right_off === 0
return left_off == 0 || right_off == 0
}

// Each: 0 = Off, 1 = Auto, 2 = On
Expand All @@ -134,6 +148,6 @@ export default class SynapticA220 extends AircraftConfig {
}

externalPower(value: number): FeatureState {
return value === 1
return value == 1
}
}
Loading