Repository navigation
Fix deadlock on session closing - #405
Open
Hackerman-ru wants to merge 1 commit into
Open
Hackerman-ru wants to merge 1 commit into
Hackerman-ru wants to merge 1 commit into
Conversation
Author
|
Hello @JoTurk, can you review this pr? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 90.94% 90.95%
=======================================
Files 20 20
Lines 1491 1492 +1
=======================================
+ Hits 1356 1357 +1
Misses 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoTurk
reviewed
Oct 19, 2026
Hackerman-ru
force-pushed
the
main
branch
2 times, most recently
from
October 19, 2026 17:22
28c0454 to
9bfc540
Compare
Author
|
Hm, maybe restart Lint check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a deadlock in Close(): it waits for the read loop, which can be
blocked on newStream if nobody is calling AcceptStream()
Drain newStream during shutdown and close the pending streams so the
read loop can exit. Add a regression test for this case.