Repository navigation
[7.x] Allow disabling Play's EvolutionsModule - #909
Merged
mkurz merged 1 commit intoOct 8, 2026
Merged
Conversation
EbeanDynamicEvolutions required an EvolutionsConfig to be injected, which only Play's EvolutionsModule binds. So with that module disabled, e.g. via play.modules.disabled += "play.api.db.evolutions.EvolutionsModule", the application failed to start with "No implementation for EvolutionsConfig was bound". Now it looks up the EvolutionsConfig only when generating the evolution scripts, which only happens with the EvolutionsModule enabled, and respects any custom binding. The existing public constructor taking an EvolutionsConfig, used e.g. with compile-time DI, is kept.
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #905 to
7.x.Play Ebean failed to start with Play's evolutions module disabled, e.g. via:
play.modules.disabled += "play.api.db.evolutions.EvolutionsModule"That's because
EbeanDynamicEvolutionsrequired an injectedEvolutionsConfig, which only that module binds. (play.evolutions.enabled = falseworked, as it keeps the module.)Now
EbeanDynamicEvolutionslooks up theEvolutionsConfigfrom the injector only when generating the evolution scripts, which only happens with the evolutions module enabled. A customEvolutionsConfigbinding still gets respected. The existing public constructor taking anEvolutionsConfig, used e.g. with compile-time DI viaEBeanComponents, is kept; the new@Injectconstructor takes Play'sInjectorinstead.Testing
EbeanWithoutEvolutionsModuleTest, which fails without this change with the error above.EvolutionsConfigthrough the injector. MiMa passes.