Repository navigation
feat(window): ask for activation tokens and activate with one - #69
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An iced app cannot let another app it starts, or asks for something, take focus.
window::gain_focusdoes nothing on Wayland, and iced has no way to get or use an xdg-activation token. So an open Chord stays behind Hive when Hive's "Open projects in Chord" asks for it.Fix
window::activation_token(id)asks for a token from that window, to hand to another app.window::activate(id, token)raises and focuses the window with a token another app handed over.revto feat(startup_notify): activate a window with another client's token winit#10, which adds the call. Merge that first, then point the pin back at the branch.Testing
cargo clippy -p iced_winit -p iced_runtime --all-features -D warningsand their tests pass.🤖 Generated with Claude Code