Prevent FullDebugMode allocation size overflow - #103
Open
maximmasiutin wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request hardens FastMM4’s FullDebugMode allocation paths by rejecting request sizes that would overflow when the FullDebugMode header/trailer overhead is added, preventing wrapped allocations and potential out-of-bounds writes during debug footer/header handling.
Changes:
- Add overflow/negative-size validation in
DebugGetMembefore callingFastGetMem(ASize + FullDebugBlockOverhead). - Add the same validation in
DebugReallocMembefore performing size-based fit checks and potential reallocation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@CodeRabbit review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unsafe FullDebugMode allocation sizes before adding debug overhead, preventing wrapped allocations and out-of-bounds footer writes.