Skip to content

feat!: drop the network action, use reconnect - #8

Merged
tygoegmond merged 1 commit into
mainfrom
feat/drop-network-action
Oct 8, 2026
Merged

tygoegmond merged 1 commit into
mainfrom
feat/drop-network-action

Conversation

@tygoegmond

Copy link
Copy Markdown
Contributor

Why

The Link action network is folded into reconnect: a reconnect gets a charger already on Plugchoice reaching Plugchoice again, including changing its network (Wi-Fi and the like), so hosts open reconnect from a "Network settings" button too. The SDK is still in beta, so network is removed outright with no deprecation shim. This is a breaking change during the beta and pairs with volttime/core#1210, which drops the network_setup capability.

What

  • iOS: remove LinkAction.network(chargerId:); doc comments point to reconnect.
  • Android: remove LinkAction.network(chargerId) and LinkAction.NETWORK; KDoc updated.
  • React Native: drop 'network' from the action union and docs/error message.
  • Example apps (iOS, Android) no longer offer network.
  • README and bridge/PROTOCOL.md action lists updated; README notes reconnect also changes the charger's network.
  • .custom(...) / any action string still passes through unchanged.
  • Tests that used the network helper now use reconnect. Unrelated uses of "network" (error code network, local network, Wi-Fi) are untouched.

Tests

  • React Native: pnpm typecheck, pnpm test (62 passed).
  • Android: ./gradlew :plugchoice:testDebugUnitTest :plugchoice:lintDebug :example:assembleDebug passed (205 tests, 0 failures).
  • iOS: xcodebuild -scheme PlugchoiceSDK test on an iPhone simulator (195 tests, 0 failures); Example app builds.

BREAKING CHANGE: LinkAction.network (iOS, Android), LinkAction.NETWORK (Android) and action: 'network' (React Native) are gone. Open reconnect instead; it also changes a charger's network.
@tygoegmond
tygoegmond merged commit 7571bc1 into main Oct 8, 2026
4 checks passed
@tygoegmond
tygoegmond deleted the feat/drop-network-action branch October 8, 2026 09:57
@github-actions github-actions Bot mentioned this pull request Oct 8, 2026
tygoegmond pushed a commit that referenced this pull request Oct 8, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](0.4.0...0.5.0)
(2026-10-08)


### ⚠ BREAKING CHANGES

* drop the network action, use reconnect
([#8](#8))

### Features

* drop the network action, use reconnect
([#8](#8))
([7571bc1](7571bc1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant