Skip to content

Pin semantic-series corpus generations and repair draft structure - #25

Open
suleman-uzair wants to merge 7 commits into
plurimath:mainfrom
suleman-uzair:docs/23-corpus-pins-repairs
Open

suleman-uzair wants to merge 7 commits into
plurimath:mainfrom
suleman-uzair:docs/23-corpus-pins-repairs

Conversation

@suleman-uzair

@suleman-uzair suleman-uzair commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

This PR pins the supporting corpus generations in PM 1009–1013 and repairs defects in the existing drafts. It separates frozen rows and recorded acceptance from coverage still missing.

  • Pin the UnitsML evaluator-reference generation and Plurimath serialized/round-trip generations, with commits, manifests, row IDs and check commands.
  • State gaps for real R 60/R 134/creep limits, expression grammar coverage, H.2 publication precision and runtime qualification.
  • Remove repeated common sections; repair the precedence table, ILAC-G8 anchor and correlation references. Remove the example's conflicting associativity adverb while preserving the existing normative left-fold rule.

The guard-ratio differences recorded in PM 1012 remain an owner decision; its k·U formula stays unchanged. MCM remains referenced.

Validation: register and stage validators, frozen evaluation-profile checks, and the exact-head Metanorma CI build pass. Generated HTML confirms single common clauses, complete precedence rows and the new corpus references. The build retains nonfatal bibliography-prefix/style diagnostics; it is not warning-free. PR deployment is skipped until upstream merge.

Refs #23; this delivers supporting pins and repairs, not completion of the missing corpus families.

Each document's conformance clause now names the testsuite commit
087e4ee6 and the generations and families that carry its vectors, with
the suite's own check scripts. Gaps at that commit are stated rather
than implied: the H.2 published last digit, the first-order H.1 row,
the kV·A quantity class, the scale-blind Quantity#== of UnitsML Ruby,
and the R 60, R 134 and creep vectors, which no suite carries yet.
PM 1012 records that the evaluator's guard ratio and extra rules differ
from clause 6 as an open decision.

Also fixes the ILAC-G8 anchor in PM 1012 (missing bracket) and the two
references to clause 6.4 in PM 1011, which point at "The result" while
the correlation term is in clause 6.1.

@ronaldtse ronaldtse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff. From the review side this is ready — when you take it out of draft I'll merge it rebase-style. What I verified:

  • The duplicate include:: blocks (01–04 re-included after 03/04) removed in pm-1009/1010/1012/1013 — same defect family as the PM 1001–1008 fix; the structure is now clean.
  • pm-1011 propagation: "the correlation term is the second sum" is the right fix — the old "stated and carried per clause 6.4" self-referenced the clause being defined; the Annex A pointer (6.4 → 6.1) matches.
  • pm-1012: the ILAC-G8 anchor was malformed (], inside the anchor) — fixed correctly.
  • Corpus pinning: every generation names its repo + commit (087e4ee, 7c13256), rows, and comparison mode; the vector indexes map each clause-10/11 acceptance vector to its rows, with honest "not yet pinned" marks; the known-gaps sections (H.2 precision, H.1 first-order, TS cross-runtime parity, MCM re-run boundary) are exactly the right disclosures.
  • pm-1013: the manifest-SHA256 discipline and the refusal-rows clarification (116 refusal rows ≠ 116 error classes) are stated unambiguously.

One decision flagged for the owner (not a blocker for this PR): the guard-ratio differences recorded in PM 1012 (the k·U guard band value) remain an owner call — the formula stays normative here, the chosen ratio stays open.

Only nit: PM 1013's pinned plurimath-testsuite commit 7c13256 — worth a one-line check that the submodule pin referenced by the specs (plurimath repo, submodules/plurimath-testsuite) matches it once the generation lands, so the two pins can't drift apart.

@suleman-uzair
suleman-uzair marked this pull request as ready for review November 16, 2026 14:55
suleman-uzair and others added 2 commits November 17, 2026 15:46
Move the supporting corpus pin from 7c13256 to b0d5148, the commit
plurimath/plurimath main uses for submodules/plurimath-testsuite. The
evaluation/ tree is identical at both commits, so cited rows are
unchanged. State that the two pins must match.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants