Skip to content

Widen scikit-learn constraint to <2 - #8

Merged
pmrv merged 1 commit into
masterfrom
claude/bump-scikit-learn-dep-c2ikzc
Jul 30, 2026
Merged

Widen scikit-learn constraint to <2#8
pmrv merged 1 commit into
masterfrom
claude/bump-scikit-learn-dep-c2ikzc

Conversation

@pmrv

@pmrv pmrv commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Pull Request Template

Description of Changes

Widens the scikit-learn version constraint in setup.py from scikit-learn<=1.4.2 to scikit-learn<2, allowing installation alongside current scikit-learn 1.x releases.

The <=1.4.2 pin dates back to a blanket version-pinning commit (0ad96ce) that also pinned numpy and pandas; those two constraints have since been widened (numpy<3, pandas>=2,<4) while scikit-learn was left behind. The only scikit-learn usage in the codebase is Ridge from sklearn.linear_model (src/pyace/linearacefit.py), a stable API across 1.x releases, so an upper bound at the next major version matches the style used for the other dependencies.

Checklist

  • Code is well-documented.
  • All tests have been run and passed.
  • Relevant documentation has been updated if necessary.

License Agreement

By submitting this pull request, I agree that:

  • The code submitted in this pull request will be distributed under the Academic Software License (free for academic non-commercial use, not free for commercial use), see LICENSE.md for more details.
  • The copyright for the code, including the submitted code, remains with Ruhr University Bochum. Ruhr University Bochum retains the right to transfer or modify the copyright.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FT7d8d2E3FansicmSzJ1SW


Generated by Claude Code

The <=1.4.2 pin came from a blanket version-pinning commit; the only
sklearn usage is Ridge from sklearn.linear_model, which is stable
across 1.x releases. Match the style of the numpy/pandas constraints.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FT7d8d2E3FansicmSzJ1SW
@pmrv
pmrv merged commit 92890a5 into master Jul 30, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants