Repository navigation
feat: new SPFx version v1.24.2 - #130
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the SPFx 1.24.2 update and its related documentation and workflow changes.
No open issues 🎉
What changed in this PR
Updates the SharePoint Framework Docker image to SPFx 1.24.2, adds matching versioned documentation, and automates Docker Hub description updates after successful image builds.
Changes:
- Bumps the SharePoint generator to 1.24.2 and updates the documented image tags.
- Adds 1.24.2 documentation, makes development-container links absolute in versioned READMEs, and updates release guidance.
- Chains Docker Hub description updates to successful image builds, using dedicated description credentials and the built commit.
| File | Description |
|---|---|
README.md |
Updates release tags and links to the 1.24.2 development-container guide. |
docs/v1.24.2/README.md |
Adds version-specific usage instructions and image tags. |
docs/v1.24.2/DevelopmentContainers.md |
Updates container examples to 1.24.2 and adjusts relative links. |
docs/v1.24.1/README.md |
Makes the development-container link absolute. |
docs/v1.24.0/README.md |
Makes the development-container link absolute. |
Dockerfile |
Pins the SharePoint generator to 1.24.2. |
AGENTS.md |
Updates versioned-documentation and release guidance. |
.github/workflows/update-dockerhub-description.yaml |
Adds post-build synchronization, built-commit checkout, and dedicated credentials. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@microsoft/generator-sharepointto 1.24.2 (Node 26 base image unchanged, still in the engine range)latest/onlineand add the1.24.2row in the README tag listdocs/v1.24.2/versioned docsdocs/DevelopmentContainers.md; each version folder now owns its copy and the root README links to the latest version's fileDOCKER_USERNAME_DESCRIPTION/DOCKER_PASSWORD_DESCRIPTIONand now runs automatically after a successful "Image Build and Push"Test plan
./scripts/test-local.shpasses: default image, pnpm hoisted linker, npm/pnpm/yarn scaffold-and-build stagesdocs/v1.24.2/resolve; no relative links remain in versioned READMEsv1.24.2, confirm the image build pushes and the description workflow runs afterwards🤖 Generated with Claude Code