Skip to content

ci: publish releases on merge, sync description on README changes - #132

Merged
DonKirkham merged 4 commits into
mainfrom
ci/auto-release
Nov 20, 2026
Merged

DonKirkham merged 4 commits into
mainfrom
ci/auto-release

Conversation

@DonKirkham

Copy link
Copy Markdown
Collaborator

Summary

  • Image Build and Push also runs on a push to main that changes Dockerfile. It reads the SPFx version from the Dockerfile, stops if that version's tag already exists, otherwise builds and pushes the image and then creates the vX.Y.Z tag on the merge commit. Tag creation stays in the same run because a tag pushed with GITHUB_TOKEN does not trigger other workflows. Manual tag pushes still re-release.
  • Update Docker Hub Description also runs on a push to main that changes README.md, skipping when the Dockerfile changed too since the build run triggers it on completion.
  • ci is one workflow again. A changes job gates build and test with a job-level if, so each event yields one pair of required checks and skipped jobs count as passing. Removes ci-skip.yml (addresses the Copilot review on docs: CI flow, root README version, path-filtered CI #131).
  • Root README uses "SPFx" after the first mention; the title reads "SharePoint Framework (SPFx) Docker images".
  • AGENTS.md: release step 7 is now "merge and watch Actions", CI flow section updated, and a new post-merge note asks whether to move the latest tag after a non-publishing merge.

Test plan

  • ci runs the full build here because ci.yml changed
  • After merge: this merge changes README.md but not Dockerfile, so "Update Docker Hub Description" should run once from the push
  • Next SPFx release: merge the release PR and confirm the tag, image, and description all appear without a manual tag push

🤖 Generated with Claude Code

DonKirkham and others added 4 commits November 20, 2026 08:47
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
paths/paths-ignore both fire on a mixed PR, so the no-op checks would
shadow the real ones. A changes job gates build and test with a job-level
if, and a skipped job counts as a passing required check.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…y changes

Image Build and Push now also runs on a push to main that changes the
Dockerfile. It reads the SPFx version from the Dockerfile, stops if that
version's tag exists, otherwise builds and pushes the image and then creates
the tag on the merge commit. Manual tag pushes still re-release.

Update Docker Hub Description also runs on a push to main that changes
README.md, skipping when the Dockerfile changed too since the build run
triggers it on completion.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 14:57
@DonKirkham
DonKirkham merged commit d765d20 into main Nov 20, 2026
4 checks passed
@DonKirkham
DonKirkham deleted the ci/auto-release branch November 20, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Change detection lacks required permissions and can fail while skipped build/test checks still satisfy branch protection, and older release runs can overwrite newer Docker Hub documentation.

3 open issues
What changed in this PR

This PR automates SPFx image releases on merge and Docker Hub description updates, while consolidating CI checks to address the split-workflow issue from #131.

Changes:

  • Publish new Dockerfile versions from main and create release tags after successful image pushes.
  • Sync README changes to Docker Hub and use one CI workflow with conditional build/test jobs.
  • Update release guidance and standardize README terminology to “SPFx.”
File Description
README.md Standardizes SPFx terminology in headings and instructions.
AGENTS.md Documents automated releases, CI behavior, and latest-tag updates.
.github/​workflows/​update-dockerhub-description.yaml Adds README-push syncing with a Dockerfile-change guard.
.github/​workflows/​ci.yml Adds change detection to conditionally run image checks.
.github/​workflows/​ci-skip.yml Removes the separate skip-check workflow.
.github/​workflows/​build-and-push.yaml Adds merge-triggered publishing and post-build release tagging.

Review effort: Balanced

Comment thread .github/workflows/ci.yml
Comment on lines +16 to +17
changes:
runs-on: ubuntu-latest
Comment thread .github/workflows/ci.yml
Comment on lines +34 to 35
if: needs.changes.outputs.image == 'true'
steps:
Comment on lines +9 to +13
push:
branches:
- main
paths:
- README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants