Repository navigation
ci: publish releases on merge, sync description on README changes - #132
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
paths/paths-ignore both fire on a mixed PR, so the no-op checks would shadow the real ones. A changes job gates build and test with a job-level if, and a skipped job counts as a passing required check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…y changes Image Build and Push now also runs on a push to main that changes the Dockerfile. It reads the SPFx version from the Dockerfile, stops if that version's tag exists, otherwise builds and pushes the image and then creates the tag on the merge commit. Manual tag pushes still re-release. Update Docker Hub Description also runs on a push to main that changes README.md, skipping when the Dockerfile changed too since the build run triggers it on completion. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Change detection lacks required permissions and can fail while skipped build/test checks still satisfy branch protection, and older release runs can overwrite newer Docker Hub documentation.
3 open issues
What changed in this PR
This PR automates SPFx image releases on merge and Docker Hub description updates, while consolidating CI checks to address the split-workflow issue from #131.
Changes:
- Publish new Dockerfile versions from main and create release tags after successful image pushes.
- Sync README changes to Docker Hub and use one CI workflow with conditional build/test jobs.
- Update release guidance and standardize README terminology to “SPFx.”
| File | Description |
|---|---|
README.md |
Standardizes SPFx terminology in headings and instructions. |
AGENTS.md |
Documents automated releases, CI behavior, and latest-tag updates. |
.github/workflows/update-dockerhub-description.yaml |
Adds README-push syncing with a Dockerfile-change guard. |
.github/workflows/ci.yml |
Adds change detection to conditionally run image checks. |
.github/workflows/ci-skip.yml |
Removes the separate skip-check workflow. |
.github/workflows/build-and-push.yaml |
Adds merge-triggered publishing and post-build release tagging. |
Review effort: Balanced
Comment on lines
+16
to
+17
| changes: | ||
| runs-on: ubuntu-latest |
Comment on lines
+34
to
35
| if: needs.changes.outputs.image == 'true' | ||
| steps: |
Comment on lines
+9
to
+13
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - README.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Dockerfile. It reads the SPFx version from the Dockerfile, stops if that version's tag already exists, otherwise builds and pushes the image and then creates thevX.Y.Ztag on the merge commit. Tag creation stays in the same run because a tag pushed withGITHUB_TOKENdoes not trigger other workflows. Manual tag pushes still re-release.README.md, skipping when the Dockerfile changed too since the build run triggers it on completion.changesjob gatesbuildandtestwith a job-levelif, so each event yields one pair of required checks and skipped jobs count as passing. Removesci-skip.yml(addresses the Copilot review on docs: CI flow, root README version, path-filtered CI #131).Test plan
ciruns the full build here becauseci.ymlchangedREADME.mdbut notDockerfile, so "Update Docker Hub Description" should run once from the push🤖 Generated with Claude Code