Repository navigation
Support non-string label values in polar signals library - #11
Merged
umanwizard merged 2 commits intoFeb 20, 2026
Merged
Conversation
umanwizard
reviewed
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often times, we end up passing in a bunch of bools/numbers/etc that we just map to String(...) everywhere before calling it. The library should just accept reasonable primitive types (number | string | boolean | undefined | null). I'm open to feedback on how to accomplish this, I had Codex update the C++ implementation (which should work on nulls/bools/etc according to it?), but a "safe" approach could also be to re-map and wrap everything in String(...) in JS land.