Repository navigation
feat: record checklist steps with steplock step done and evidence - #238
Merged
Merged
Conversation
Block messages told the agent to run `sh .../ack.sh`. Claude Code auto mode reads that as the agent approving its own safety gate and refuses it, so agents in auto mode could not finish any checklist. - New `steplock step done <checklist> <step> --session <id> --evidence` checks the step is current and the outcome is valid, advances state, and logs the evidence to audit.log as a `step_done` event. - Block messages read as a checklist step and show that command. With allow_preview_request, the first block lists every step inline. - Gates never block a plain `steplock step ...` command (no shell control characters), so evidence that quotes a gated command works. - ack.sh and preview.sh are still written (deprecated) for old sessions. - Promote clippy::unused_self to deny. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When finished, run: sh ~/.config/steplock/sessions/<id>/<flow>/ack.sh. Claude Code auto mode flags this as "Auto-Mode Bypass", because the agent runs an opaque script that approves its own gate. Agents in auto mode cannot finish any steplock checklist.Checklist step 2 of 18. Do what it asks, then record the result: steplock step done <checklist> <step> --session <id> --evidence "<what you did and what you saw>". steplock checks that the step is the current one and that the--nextoutcome is valid. It writes the evidence toaudit.logas astep_doneevent. A wrong or repeated step fails and changes nothing.steplock step ...command, so evidence that quotesgit pushorgh pr mergedoes not deadlock. Commands with;&|<>$, backtick or newline are gated as usual.allow_preview_request = truenow lists every step in the first block message. Before, it pointed topreview.sh, and the agent had to read a file under~/.config/steplock.ack.shandpreview.share still written to each session dir (deprecated, documented in Architecture.md). Old sessions keep working.clippy::unused_selfto deny (ratchet rule).Test plan
cargo testpasses (newstep_tests.rsunit tests plus a CLI end-to-end test: block, then step done withgit pushin the evidence, then the retry is approved and the evidence is in the audit log)cargo clippy --all-targets -- -D warningspassescargo fmt -- --checkpasses.steplock/🤖 Generated with Claude Code