Repository navigation
Conversation
Add `string_add = "deny"` to the `[lints.clippy]` table and rewrite the single violation in `scripts.rs` to build the script with `push` instead of `String + &str`. Opened by the moadim routine "Clippy lint improvements -> issue + PR (Rust repos) -> Slack". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239
What
Promote one more Clippy lint in the incremental ratchet:
clippy::string_add = "deny"in the[lints.clippy]table ofcore/Cargo.toml.clippy::string_addflags string concatenation through the+operator (a + &b,a + "\n") and asks forString::push_str()/String::push()instead. That makes the mutation and the ownership move explicit, and it reuses the existing buffer rather than reallocating per concatenation.The lint pairs with
clippy::format_push_string,clippy::manual_string_newandclippy::str_to_string, which the crate already denies, so all string building now follows one idiom.Changes
core/Cargo.toml: addstring_add = "deny".core/src/scripts.rs: the one violation the lint surfaced.lines.join("\n") + "\n"becomes a namedStringwith apush('\n'). Same output, no behaviour change.Verification
Run in
core/:cargo fmt --check— cleancargo clippy --all-targets --all-features— no issuescargo test— 191 passedThis pull request was opened automatically by the moadim routine "Clippy lint improvements → issue + PR (Rust repos) → Slack".