Repository navigation
Retire unproduced BanSafe trigger fixtures - #36
Merged
Merged
Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API no longer produces
bansafe.risk_changed,bansafe.health_changed, orbansafe.enforcement, and the SDK no longer offers their test fixtures. Remove the retired trigger example and fixture list from the CLI guidance. Pin the published SDK that rejects those fixture names, and test that the CLI rejects each one before sending a request.Contract and release impact:
polymorfa/polymorfa@6839976eretired the three names from the authoritative webhook and Test event contracts (PR #301). No API handler changes occur in this CLI PR.polymorfa/sdks@c98cbef73e2f39516b791cef1d02cab4b53bb787removed the TypeScript fixture and webhook types (PR #298). This CLI pins the inspected npm artifact@polymorfa/sdk@0.1.0-dev.20260926005918exactly in its manifest and lockfile.triggerhelp and README list only supported fixtures; retired names fail CLI argument validation before transport. Existing BanSafe inspection commands are unchanged.Validation on Node 22: clean
npm ci; focused trigger suite (12 passed);npm run verify(format, lint, typecheck, 856 tests across 87 files, build, pack dry run, production audit); runtimepolymorfa versionreports the pinned SDK. The SDK publish workflow passed for the merged commit, and npm serves the exact version with thedevtag and integrity metadata. No live Test number delivery was exercised.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.