Repository navigation
Validate webhook test input for team and project owners - #39
Merged
Merged
Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 8 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 63 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Comment |
purpshell
force-pushed
the
codex/cli-webhook-test-owner-input-20260926
branch
from
September 26, 2026 10:44
4a0fc52 to
b14c335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polymorfa webhook test --owner organization --input ...passed project-onlybodyandsessionIdfields through to the API, which rejects them with HTTP 400. The command now checks owner input before calling the SDK: team tests accept onlyeventType, and project tests requirebodyandsessionIdtogether. Help, package guidance, and the webhook skill explain the two forms.This change builds against the existing exact
@polymorfa/sdk@0.1.0-dev.20260926005918pin. Its package-lock integrity matches the npm registry (sha512-PAkVAqN5QNSKcoT4i7DJHDRp5RfKbDmiJUDurkgxJYOyFR4d+wJ65HrAqkY5KGvBjtANsjkqRczmt8gQRAnGVw==). The current SDK already exposeswebhooks.test, so this CLI validation does not need an unpublished package to compile. API contract clarification is polymorfa/polymorfa #352, with spec source commit9be29db321ecdb8e164bbf33d5b2cb1f4ff12c91; the matching owner-specific SDK types are polymorfa/sdks #312. Those are separate merge and publication gates.Five-part assessment:
Validation:
developer-webhooks.test.ts(18 passed), typecheck, and focused ESLint passed against the exact installed SDK pin. No authenticated or live webhook test was run. Exact-head CI is the broader gate.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.