Skip to content

Add CLI group Calls, media and social controls, and record detail - #44

Merged
purpshell merged 13 commits into
devfrom
codex/calls-continuation-20260926
Sep 26, 2026
Merged

purpshell merged 13 commits into
devfrom
codex/calls-continuation-20260926

Conversation

@purpshell

@purpshell purpshell commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

The CLI could place one call but lacked group origination, participant re-ring, microphone state, reactions, raised hands and scoped call-record detail. This draft adds those commands with local validation and truthful output. calls place-group accepts 2–31 distinct public recipients or one existing public group ID; invalid and mixed destinations are refused before transport.

New commands guard for SDK methods before sending a request. The declared registry dependency remains @polymorfa/sdk@0.1.0-dev.20260926005918, so this source work is not an available release. Call-link CLI commands are preserved on an isolated source branch but excluded here until a matching SDK is published, verified by exact version and integrity, and pinned with a regenerated lockfile.

Verification: format, lint, typecheck, Node 22 build and 36 focused Calls/record tests passed locally; four version-dependent cases are skipped against the declared registry SDK. Real phone and group acceptance remain open.

Six-part scope: API handlers, scope checks, specs and refusal paths are in API PR 337; SDK methods/types and browser UI are in SDK PR 306; CLI commands, help, outputs and errors are updated here; Calls/CLI guides are updated while customer release copy waits for deployment; existing Calls entitlement and operational disable still govern access; existing Admin diagnostics, Number calling, SIP and retention controls suffice because these commands add no staff setting.

These source commands remain guarded until a matching SDK is published and pinned; live acceptance is a separate release gate. Recording requires a separate storage and consent decision. Call transfer was deferred by the owner.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9bd3a6c3-b071-4af6-a0ea-d917cc677799

📥 Commits

Reviewing files that changed from the base of the PR and between 8bacf9f and f560bb6.

📒 Files selected for processing (17)
  • README.md
  • src/commands/calls/hand.ts
  • src/commands/calls/list.ts
  • src/commands/calls/media.ts
  • src/commands/calls/place-group.ts
  • src/commands/calls/react.ts
  • src/commands/calls/ring.ts
  • src/commands/calls/view.ts
  • src/services/call-analytics.ts
  • src/services/call-media-controls.ts
  • src/services/calls.ts
  • src/services/sip-trunks.ts
  • test/commands/call-media-controls.test.ts
  • test/commands/call-records.test.ts
  • test/commands/calls-social.test.ts
  • test/commands/calls.test.ts
  • test/commands/sip-trunks.test.ts

Comment @coderabbitai help to get the list of available commands.

@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T21:33:19.894117Z f560bb6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: f560bb6239

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@purpshell
purpshell marked this pull request as ready for review September 26, 2026 21:39
@purpshell
purpshell merged commit a32c795 into dev Sep 26, 2026
3 checks passed
@purpshell
purpshell deleted the codex/calls-continuation-20260926 branch October 26, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant