Repository navigation
Add CLI group Calls, media and social controls, and record detail - #44
Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 2 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (17)
Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The CLI could place one call but lacked group origination, participant re-ring, microphone state, reactions, raised hands and scoped call-record detail. This draft adds those commands with local validation and truthful output.
calls place-groupaccepts 2–31 distinct public recipients or one existing public group ID; invalid and mixed destinations are refused before transport.New commands guard for SDK methods before sending a request. The declared registry dependency remains
@polymorfa/sdk@0.1.0-dev.20260926005918, so this source work is not an available release. Call-link CLI commands are preserved on an isolated source branch but excluded here until a matching SDK is published, verified by exact version and integrity, and pinned with a regenerated lockfile.Verification: format, lint, typecheck, Node 22 build and 36 focused Calls/record tests passed locally; four version-dependent cases are skipped against the declared registry SDK. Real phone and group acceptance remain open.
Six-part scope: API handlers, scope checks, specs and refusal paths are in API PR 337; SDK methods/types and browser UI are in SDK PR 306; CLI commands, help, outputs and errors are updated here; Calls/CLI guides are updated while customer release copy waits for deployment; existing Calls entitlement and operational disable still govern access; existing Admin diagnostics, Number calling, SIP and retention controls suffice because these commands add no staff setting.
These source commands remain guarded until a matching SDK is published and pinned; live acceptance is a separate release gate. Recording requires a separate storage and consent decision. Call transfer was deferred by the owner.