Repository navigation
Make CLI doctor fail on unvalidated or ambiguous credentials - #47
Merged
Merged
Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 36 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polymorfa doctorcould exit 0 after skipping credential validation, and it silently chose one key when multiple credential environment variables were set. A no-credential run also treated the missing credential as a warning. These results made a green diagnostic misleading.Doctor now exits 1 for missing or unvalidated credentials and reports conflicting environment credentials without sending either to the API. An explicit
--profilestill takes precedence. A server API key that authenticates but cannot list projects still produces a 403 warning; a rejected 401 key fails. Output remains redacted. CLI help and README describe the exit behavior.The matching public guide is in polymorfa/polymorfa PR #384, based on CLI commit
60b083555643f823356a7f3b209330e397904a0b. Merge the guide with this change; do not publish the CLI until its separate release gates are satisfied.Verification: 18 focused service and command tests passed, including actual command success and exit-code-1 paths. The full CLI suite passed (872 tests in 89 files), as did typecheck, lint, build, formatting, and diff checks. The paired Mintlify page passed broken-links, validate, and accessibility checks. No live API credentials or deployed environment were exercised.
Contract assessment: API and SDKs are unaffected; no wire shape, scope, or SDK method changes. CLI is updated here. Public docs are updated in PR #384; no changelog entry claims unpublished CLI behavior as shipped. Feature releases are unaffected because this local diagnostic has no flag, entitlement, or enrollment change. Admin controls are unaffected because no staff view or action changes.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.