Skip to content

Add local Bash, Zsh, and Fish completion - #52

Merged
purpshell merged 4 commits into
devfrom
codex/cli-shell-completion-20260926
Sep 26, 2026
Merged

purpshell merged 4 commits into
devfrom
codex/cli-shell-completion-20260926

Conversation

@purpshell

@purpshell purpshell commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

polymorfa completion bash|zsh|fish now prints a shell script that completes command names, flags, and fixed flag choices from the installed CLI. The hidden suggestion command reads local oclif metadata only; completion does not fetch credentials, query profiles or projects, or call the API. The README shows how source-build users load each script.

Validation: Node 22, 879 CLI tests across 91 files with two workers; focused completion tests; formatting, lint, typecheck, build, npm pack dry run, and production audit. Generated Bash and Zsh scripts were exercised in their shells for polymorfa auth lo; Fish is not installed locally, so its script was checked by output tests. No live feature test or npm publication.

API: unaffected; no route, auth, shape, or protocol changes. SDKs: unaffected; completion uses CLI metadata without an SDK call. CLI: command, hidden suggestion path, shell scripts, help, README, and tests updated. Docs: paired Mintlify PR polymorfa/polymorfa#386 covers the source-build audience; merge it before this PR. Feature release: local source-build functionality only, without server flag, entitlement, enrollment, deployment, or shipped changelog. Admin control: unaffected; no staff capability or UI changes.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 33703a2b-f395-4ed0-84be-1e8d7b6a322f

📥 Commits

Reviewing files that changed from the base of the PR and between 8f15b2f and 43abaf6.

📒 Files selected for processing (6)
  • README.md
  • src/commands/completion.ts
  • src/commands/completion/suggest.ts
  • src/services/completion.ts
  • test/commands/completion.test.ts
  • test/services/completion.test.ts

Comment @coderabbitai help to get the list of available commands.

@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T21:42:32.572835Z 43abaf6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12566b815b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/services/completion.ts
Comment thread src/services/completion.ts
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b49dd0a56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/services/completion.ts
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 43abaf6d94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@purpshell
purpshell merged commit 75131eb into dev Sep 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant