Repository navigation
feat: add safe local listener forwarding options - #53
Conversation
|
@codex review |
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 39 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f319ef3dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
polymorfa listencan now add custom headers to forwarded event requests with repeatable-H 'Name: value'and accept self-signed loopback HTTPS handlers with--skip-verify. Reserved authentication, framing, and Polymorfa signature headers are protected; invalid header values are never echoed. Custom headers cannot cross an origin-changing redirect, and TLS verification for the Polymorfa API and public forwarding destinations remains enabled.The existing
--jsonalready provides JSONL output, so no duplicate--print-jsonflag was added. The listener generates a per-run local signing secret; its accepted contract requires--forward-secret-outfor JSON/noninteractive forwarding and forbids stdout/JSONL disclosure, so no--print-secretflag was added.Validation: format, lint, typecheck, all 887 tests, and build passed locally. Tests cover exact forwarded bytes/signature, custom header validation and delivery, cross-origin redirect refusal, self-signed loopback HTTPS opt-in, public-target refusal, flag dependencies, and secret-safe errors. No live webhook or npm publication was performed.
Five-part assessment: API handlers/specs and SDK contracts are unaffected because these flags only change CLI-to-local-handler forwarding, after the existing listener authorization and payload stream. CLI command, forwarding transport, help, README, and tests are updated. Source-build Mintlify documentation is paired in polymorfa/polymorfa#389 and must merge before this PR. This local CLI behavior needs no feature-engine flag or entitlement change; the CLI remains unpublished on npm, and publication/deployed acceptance are separate release gates.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.