Skip to content

Add testing phone commands for Test numbers - #72

Draft
purpshell wants to merge 1 commit into
mainfrom
t3code/testing-phone-controls
Draft

purpshell wants to merge 1 commit into
mainfrom
t3code/testing-phone-controls

Conversation

@purpshell

@purpshell purpshell commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Summary

Adds polymorfa testing phone get|send|unlink for a Test number's simulated phone:

  • get shows whether the phone is online and which devices are linked.
  • send --to --text sends a text as the phone to another running Test number in the project.
  • unlink --device unlinks a device. Device IDs outside 1 to 99 are refused before any request.

Commands call the SDK methods in polymorfa/sdks#341, which cover the routes in polymorfa/polymorfa#526. Draft until #341 is merged and published as a 0.1.0-dev.* prerelease, when this PR moves its @polymorfa/sdk pin to that version.

Impact

Impact table

Area Updated / blocked Change or named blocker Paths / evidence
CLI commands Updated Three commands and a shared target helper src/commands/testing/phone/*, src/testing-phone.ts
CLI README Updated "Test number phone" section README.md
SDK dependency Blocked Pin waits for the SDK prerelease from polymorfa/sdks#341 package.json
Public docs Updated in the monorepo Phone controls guide, polymorfa/polymorfa#536 polymorfa/polymorfa#536

No impact table

Area Why there is no impact Supporting paths or evidence
Credentials and profiles Uses the existing server API key path (serverApiKeyOnly); no new credential handling base-command.ts messagingClient
MCP tools The local MCP server adds no phone tools in this change no MCP files changed
Feature release, billing, Admin API-side gates in polymorfa/polymorfa#526; the CLI adds no flag or default polymorfa/polymorfa#526

Verification

  • With the SDK from Add Test number phone controls to the TypeScript SDK sdks#341 installed locally (npm install --no-save of its packed build, not committed): tsc clean, npm run build passes, the full suite passes (109 files, 1032 tests), and the new test/commands/testing/phone.test.ts passes 5 tests. They cover request paths and bodies, human and JSON output, refusing device 0 before any request, and the missing --session message.
  • ESLint and Prettier clean on the changed files.
  • Not yet exercised: CI against the published prerelease. CI fails until the pin moves.

Session provenance and UI evidence

  • Session checkpoint: internal/agent-sessions/sessions/purpshell-t3-claude/test-number-parity-merge/218b8b1df35ee9ecb995ac3a303464f7bc2df99e7376a173c2bac251759a3851.md in polymorfa/polymorfa at 6d3c2a680f03ab765c2dab80d1cb2ef80dfb9ee0 (registration PR polymorfa/polymorfa#518).
  • UI evidence: CLI only, no UI.

Rollout and rollback

Merge after polymorfa/sdks#341 publishes and the pin moves. Additive commands; revert to roll back.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

testing phone get, send and unlink call the Testing phone routes from
polymorfa/polymorfa#526 through the SDK methods in polymorfa/sdks#341.
The SDK pin moves to the prerelease that contains them before merge.
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant