Repository navigation
Conversation
testing phone get, send and unlink call the Testing phone routes from polymorfa/polymorfa#526 through the SDK methods in polymorfa/sdks#341. The SDK pin moves to the prerelease that contains them before merge.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
polymorfa testing phone get|send|unlinkfor a Test number's simulated phone:getshows whether the phone is online and which devices are linked.send --to --textsends a text as the phone to another running Test number in the project.unlink --deviceunlinks a device. Device IDs outside 1 to 99 are refused before any request.Commands call the SDK methods in polymorfa/sdks#341, which cover the routes in polymorfa/polymorfa#526. Draft until #341 is merged and published as a
0.1.0-dev.*prerelease, when this PR moves its@polymorfa/sdkpin to that version.Impact
Impact table
src/commands/testing/phone/*,src/testing-phone.tsREADME.mdpackage.jsonNo impact table
serverApiKeyOnly); no new credential handlingbase-command.tsmessagingClientVerification
npm install --no-saveof its packed build, not committed):tscclean,npm run buildpasses, the full suite passes (109 files, 1032 tests), and the newtest/commands/testing/phone.test.tspasses 5 tests. They cover request paths and bodies, human and JSON output, refusing device 0 before any request, and the missing--sessionmessage.Session provenance and UI evidence
internal/agent-sessions/sessions/purpshell-t3-claude/test-number-parity-merge/218b8b1df35ee9ecb995ac3a303464f7bc2df99e7376a173c2bac251759a3851.mdin polymorfa/polymorfa at6d3c2a680f03ab765c2dab80d1cb2ef80dfb9ee0(registration PR polymorfa/polymorfa#518).Rollout and rollback
Merge after polymorfa/sdks#341 publishes and the pin moves. Additive commands; revert to roll back.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.