Repository navigation
ci: run CLI checks on disposable ci-1 workers - #84
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 2 files. (4 skipped: 4… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: moving CLI checks to disposable ci-1 workers. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 2 files. (4 skipped: 4 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cf118826d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Move CLI checks from the paused Blacksmith workflow to disposable ci-1 workers managed by the qualified GARM + Incus controller. Preserve the CI/Verify Node 22 names, Node matrix, permissions, npm cache and all three existing commands. The new workflow identity permits PR qualification while old paid workflow 338004193 stays disabled. Use the existing eight-CPU pool to qualify alongside the monorepo general queue without increasing host limits. No paid fallback.
Impact
Impact table
.github/workflows/ci1.yml,scripts/verify-ci1-image.py,internal/docs/ci1-runners.mdNo impact table
src/,package.json,package-lock.jsonunchangedVerification
Head
76b51309bb4677f456d60cf6cdf52ea31ee7b13a; source dependency CLI mainc21af71f13e68230769d1a2ca17985d143bf6c6e.npm ciandnpm run verifypassed locally with Node 22.23.3: all 110 test files and 1,051 assertions, lint, types, formatting, build, package dry-run and production audit (zero production vulnerabilities). npm's install report includes existing development-dependency advisories; the production-only audit policy is unchanged.505d3336ea46318175907ac2192df5002406731bd2990a344ba2ee98c1c89ab0has independent host/tool/network, source-triggered API suite, cancellation cleanup, controller restart and reboot proof in monorepo PR 781. CLI GitHub qualification separately passed in 39305060451, job 118239858798, runner garm-swxbceswhgol on ci1-integration. The image gate, all 110 test files/1,051 assertions, three release-evidence tests, build, package and production audit passed. No default-branch result is inferred. The CodeRabbit result while draft was a review skip; no substantive automated review is claimed.Review findings
sha256sum --check --strict; a real GNU checksum regression verifies a valid file succeeds and adding a malformed row fails. Reproduced failure before the fix.Controller readback receipt. Seven local boundary tests, actionlint, zizmor, formatting and diff checks pass. No image, pool, host budget, product runtime, package dependency or lockfile changed. Current-head GitHub qualification passed in 39307546365 on 76b5130. All steps succeeded, including the seven admission tests, all 110 source test files/1,051 assertions, zero production vulnerabilities and three release-evidence tests. The worker garm-tqxuipxwbdqi was absent from both GARM and Incus after completion. CodeRabbit cleared the current head; all three review threads were resolved before the exact-head merge.
Session provenance and UI evidence
8ad9e447-6fd5-4fc5-8e96-189326af2c28; existing registration https://github.com/polymorfa/polymorfa/pull/511 reused.76b51309bb4677f456d60cf6cdf52ea31ee7b13a. Visible instructions and selected outcomes only; excludes private keys, credentials, raw logs, attachments, authentication screens and hidden reasoning. No automatic capture claim.Rollout and rollback
Confirmed migration plan. CLI operator record.
Qualify this exact source on ci-1, inspect checks/reviews/conflicts, merge the CI-only change and verify its first main-branch run. The dedicated App is already installed on this private repository; no new permissions or secrets are added. Host bounds remain two VMs and 12 CPUs/48 GiB aggregate; each job receives a fresh VM. Fork source never checks out or runs on ci-1. A fork-originated request uses a GitHub-hosted runner only for the failing pre-checkout guard, so the preserved Verify Node 22 check cannot pass through a successful skip. Trusted source always uses ci-1.
Do not enable old paid workflow 338004193 as an automatic fallback. Drain/rebuild or choose a previously qualified image on failure, then requalify. Publishing retains its existing schedule/manual and exact SDK/API acceptance gates; merging this CI change does not publish a package. No product deploy or package publication is authorized. Staging admission is fenced separately and PR 744 stays held.