Repository navigation
Reconcile SDK contracts with native releases and campaign updates - #320
Conversation
|
@codex review |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (31)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe TypeScript SDK adds campaign update and reschedule methods, send-window types, and typed Platform campaign results. It also updates message, history, QuickLink, and webhook types, removes several BanSafe event contracts, and synchronizes examples, documentation, fixtures, and coverage records. ChangesCampaign and campaign API
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Caller
participant MessagingCampaignsResource
participant withIdempotencyKey
participant CampaignsAPI
Caller->>MessagingCampaignsResource: Call reschedule with campaign ID and request body
MessagingCampaignsResource->>withIdempotencyKey: Process request options
MessagingCampaignsResource->>CampaignsAPI: POST to campaign reschedule endpoint
CampaignsAPI-->>MessagingCampaignsResource: Return campaign operation
MessagingCampaignsResource-->>Caller: Return API response
Merge Risk: ⚪ Minimal · up to The campaign and webhook contract updates have no established merge-blocking issue. Rescheduling matches the pinned API contract, and snapshot metadata and coverage counts are consistent. Merge after normal checks pass. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 22 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dc35625a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1091ea02b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a3e3a9460
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4328430952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Copy the Messaging and Platform OpenAPI snapshots byte for byte from polymorfa/polymorfa 5c8014d7d58b4d3e483d9d124ee9d88bd85820f9 (PR #388 merged into dev) and reconcile the ledger: 529 operations, 381 covered, 1 partial, 15 missing, 132 excluded, 0 changed. Type campaign send windows, the open PlatformCampaign result, QuickLink reauthorization purpose, hosted-history mediaRetrieval and participant handRaised.
…e.received (cherry picked from commit 2f87772)
Cherry-picked reply choice types from SDK dev; add message.ack pricing and webhook participant handRaised; record the reviewed ledger changes.
The SDK contract snapshots were pinned before the native feature decision gained
experimentRevision. Refreshing from the exact API source also brings three Campaigns operations and the updated webhook catalog into view. This PR copies the Messaging and Platform OpenAPI files byte for byte frompolymorfa/polymorfacommit5c8014d7d58b4d3e483d9d124ee9d88bd85820f9, the merge of PR #388 intodev(first coordinated at PR source commit2f24c1d62), reconciles every operation fingerprint, and adds typed campaign update and reschedule methods.The SDK now removes retired BanSafe webhook events and test fixtures, types
campaign.rescheduled, and limits organization webhook tests to their documented input.Repinning to the merge commit adds 17 operations and changes 236 fingerprints (none removed). 211 changes only add documented rate-limit response headers. The rest are typed in this PR: campaign
sendWindowon both surfaces and a typed openPlatformCampaignresult for Platform list, get, create and update; the QuickLinkreauthorizationpurpose; hosted-historymediaRetrieval; participanthandRaised; and webhookreplyChoice/parentMessageId(cherry-picked from SDKdev) plusmessage.ackpricing.MessagingClient.voip.placeis partial: the API now acceptsparticipantsorgroupId, which SDKdevimplements but thismain-based branch does not. The referral route is absent from the pinned specs, so referrals stay Console-only.Uncovered new operations (recorded in the ledger, no new methods invented): 15 missing. Six Calls operations (call links, link preview, raised hand, ring participant, call reaction,
GET /platform/calls/{callId}) are implemented on SDKdev. Nine Official API operations have no typed method: four Cloud template routes (proposed in #308), stored message media (proposed in #316), service window, credential health, credential reauthorization and Meta pricing summary. Two Console account-health routes are excluded.Verification at head: format, lint, typecheck,
build:workspaces, full tests (116 files, 1,302 tests),build, strict coverage (529 operations: 381 covered, 1 partial, 15 missing, 132 excluded, 0 changed), Functions coverage, retired-name checks,npm pack --dry-runandnpm audit --omit=devall passed.Six-part assessment:
devas5c8014d7d); this PR copies the authoritative Messaging and Platform specs from that merge commit and changes no API runtime.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
New Features
Documentation