Repository navigation
fix: remove machine access to key and project token management - #354
Conversation
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 1 minute. View limit details
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Organization keys and project tokens can no longer list or revoke long-lived credentials through the public API. Remove Client.apiKeys and Client.projectTokens, their resources/types/exports, and all associated examples and documentation. Client-token operations remain.
API source for the removal: polymorfa/polymorfa commit cdc3d8dd2770693f1d319ecf5d0fa1a058717a0d. contracts/credential-management.json pins the exact narrow delta and source spec hash; existing full snapshots retain their baseline provenance. Analytics source hashes remain the original source hashes; SDK snapshot hashes reflect only the credential-removal delta. No unrelated API parity is claimed.
Six-part impact:
Validation: typecheck, build, lint (two existing unused eslint-disable warnings), 47 affected coverage/export/resource/clean-packed-consumer tests pass. Full Node 24 suite passed 1544/1546 before updating the two changed inventory expectations; both corrected suites pass. Strict coverage reports 605 operations: 451 covered, 140 excluded, 14 pre-existing Campaigns gaps, zero changed. The gate is unchanged; these are explicitly recorded baseline gaps, so they do not fail strict drift validation. Initial Node 26 full-suite composer/TLS environment failures disappear with Node 24.
Blocked delivery: polymorfa/sdks repository secrets SDK_COVERAGE_CLIENT_ID and SDK_COVERAGE_APP_PRIVATE_KEY are absent. The main publication workflow requires them for its App token step, so publication remains blocked; no secret or workflow workaround is included. dev and main are distinct: this PR targets dev as explicitly requested; default main publication needs a deliberate forward-port/accepted release. No published package, registry-only install or deployed acceptance is claimed. This remains draft while required delivery gates are blocked.
Companion delivery: https://github.com/polymorfa/polymorfa/pull/641 · #354 · polymorfa/cli#83
Publication blocker reproduced in the existing main workflow run: https://github.com/polymorfa/sdks/actions/runs/39010443783 fails with “client-id (or deprecated app-id) input must be set to a non-empty string.” Credentials were not changed or exercised.