Repository navigation
Conversation
…SDKs Claims and bansafe.claim webhooks gain linked_device_interactive and referral_group_send, and claim evidence gains linkedDeviceInteractive and referralGroupSend (polymorfa/polymorfa#845). Rust's closed verdict enums rejected the new values; the other languages now type them too. The contract supplement pins API source 5ccd3dcb and stays unpublished. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ban Credit claims gain two verdicts,
linked_device_interactiveandreferral_group_send, plus the evidence flagslinkedDeviceInteractiveandreferralGroupSend(polymorfa/polymorfa#845). All six server SDKs now type them on claim reads andbansafe.claimwebhooks.ClaimVerdictand the webhookBanSafeClaimVerdictare closed serde enums. Before this change, a claim or webhook carrying either new verdict failed to deserialize.Literaltypes and phpstan shapes add both values. The evidence types add both flags. Runtime decoding was already pass-through.matchon the verdict enums andClaimEvidencestruct literalsBanSafeClaimEvidenceliteralsBanSafeClaimEvidenceconstructor and Deconstructcontracts/ban-credit-waivers.jsonpins the verdict enums and evidence fields to API source5ccd3dcb(#845 head), withpublished: false.Verification
ban-credit-waivers-contract.test.tschecks the exhaustive verdict maps and evidence types against the pinned spec.npm run typecheck, eslint andprettier --check .pass.node scripts/check-native-coverage.mjsandnpm run check:coveragereport no gaps.tests/ban_credit_waivers.rsround-trips both verdicts on both enums and the evidence. Fullcargo testpasses (289), andcargo fmt --checkis clean.ban_credit_waivers_test.gopasses, along with the fullgo test ./...and gofmt.test_ban_credit_waivers.pypasses, along with the full pytest run (1709), mypy and ruff.GetClaimAsyncand decodes the webhook payload.--bansafe-onlyand--simultaneous-calls-onlypass, anddotnet formatis clean for changed files.Dockerfile.testimage (PHP 8.2):tests/run.phpneedsexamples/php/web-hostdependencies that were not installed locally.packages/elements/test/native-bridges.test.tsfails in the same 5 cases onmain. Not related to this change.Release status
Source only. The API change (#845) is a draft and unmerged. Re-pin the supplement to the merged API revision, and wait for staging acceptance, before any package includes this.
Need help on this PR? Tag
@codesmith-botwith what you need.Current source status, 28 October 2026
Head
b64683984be4efef665e6680eea276ed266530aaremains source-only and blocked. Snippet inventory and native package receipt/version checks are red in runs40259917416/40259917460; no rerun or publication was requested. Re-pin after the final #845 producer, then qualify all six SDKs and the CLI against it. Matching staging/production and registry installation gates remain. Source-pinned dependency and internal impact evidence. Release coordinates merge slot/executor; no current approval or merge is claimed.