Conversation
Signed-off-by: Werner de Carne <werner@carne.de>
Contributor
|
Let's please close this in preference of #638 |
Author
|
Fix in #638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When TDB support is enabled,
ppp_safe_fork()closes the child's TDB context but leavespppdbpointing to the freed context.Before executing a script,
run_program()callsppp_script_setenv()to setPPP_SCRIPT_INSTANCE. This can access the closed TDB context throughupdate_db_entry(), resulting intdb_store failed: Locking errormessages and potentially a crash.Set
pppdbto NULL after closing it in the child to prevent further access.Tested by applying the patch to pppd 2.5.4 on Gentoo, rebuilding from source, and rebooting. The previously observed TDB locking errors no longer appeared. Shutdown and reconnection paths have not yet been separately verified.
Diagnosis and patch proposed by OpenAI ChatGPT (Codex), reviewed and tested by me.
Fixes #636