Repository navigation
Core: Expose max HTTP body size control (#218) - #224
Open
Aditya-9-6 wants to merge 1 commit into
Open
Aditya-9-6 wants to merge 1 commit into
Aditya-9-6 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #218 by porting PBC-Java PR prebid/prebid-cache-java#192.
Description
In high-throughput environments and large VAST store requests, operators need control over incoming HTTP body sizes to prevent unbounded memory consumption while also having the flexibility to allow legitimate larger payloads (>256KB/512KB).
This PR:
request_limits.max_body_size_bytesconfiguration option in bytes (followingrequest_limits.max_header_size_bytesconvention introduced in Config max request header size #174).262,144bytes (256 KB), matching PBC-Java.server.max-http-body-size-kb(PBC-Java syntax), automatically converting KB to bytes.http.MaxBytesReader.HTTP 413 Payload Too Large(http.StatusRequestEntityTooLarge) with error message"Request body exceeded maximum size."and records bad request metrics. Setting the limit to0disables body size limiting.