Skip to content

fix: make buf lint pass with an explicit DiffPromptResponse exception #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sujal-maheshwari2004 merged 1 commit into from
Oct 18, 2026
Merged

fix: make buf lint pass with an explicit DiffPromptResponse exception #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,12 @@ jobs:
with:
go-version-file: go.mod
- run: go test ./...

buf:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: bufbuild/buf-action@v1
with:
setup_only: true
- run: buf lint
14 changes: 12 additions & 2 deletions gen/priompt/v1/prompt_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion proto/priompt/v1/prompt.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ service PromptService {
// DiffPrompt runs the Semantic Propagation Diff between the stored prompt at
// `uri` (the original) and `new_template` (the edit), using the embedding
// model the server operator configured at startup.
// DiffPromptResponse is shared with DiffCommits on purpose (same result shape);
// splitting it would break the Go API and buf breaking.
// buf:lint:ignore RPC_REQUEST_RESPONSE_UNIQUE
rpc DiffPrompt(DiffPromptRequest) returns (DiffPromptResponse);
// PublishPrompt validates and stores a new prompt version on the server, then
// notifies subscribers over NATS. This is the write-through path that makes a
Expand All @@ -24,7 +27,9 @@ service PromptService {
// MergeBranch merges `from` into `into`, recording a two-parent merge commit.
rpc MergeBranch(MergeBranchRequest) returns (MergeBranchResponse);
// DiffCommits runs the semantic diff between any two commits of a prompt — the
// query-anything-in-history path.
// query-anything-in-history path. Returns DiffPromptResponse (see DiffPrompt).
// buf:lint:ignore RPC_REQUEST_RESPONSE_UNIQUE
// buf:lint:ignore RPC_RESPONSE_STANDARD_NAME
rpc DiffCommits(DiffCommitsRequest) returns (DiffPromptResponse);
// SetBranch points a branch at an existing commit — the rollback / pin path.
// Moving "main" instantly changes the served version.
Expand Down
Loading