Repository navigation
docs: document Commit.created_at as RFC3339Nano - #8
Merged
Merged
Conversation
The server formats Commit.created_at with time.RFC3339Nano in UTC (variable-length fractional seconds), but the proto comment said RFC3339. Describe the actual format and how to parse it, and regenerate the Go stubs (comment-only change). Fixes #4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Commit.created_atwas commented// RFC3339. The server sendstime.RFC3339Nanoin UTC:internal/server/server.go:CreatedAt: c.CreatedAt.Format(time.RFC3339Nano)created.UTC().Format(time.RFC3339Nano)Historyresponse:"createdAt": "2026-10-18T04:45:25.5540023Z"(7 fractional digits)RFC3339Nano trims trailing zeros, so the fraction can have anywhere from 0 to 9 digits. A client that parses a fixed
RFC3339layout or a fixed width will fail.The fix
Replaced the trailing comment with a leading comment that gives the actual format (UTC, RFC 3339 with 0-9 fractional digits and trailing zeros trimmed), an example, and parsing guidance. Regenerated the Go stubs with pinned
protocolbuffers/go:v1.36.12/grpc/go:v1.6.2. Inprompt.pb.goonly the doc comment and the gofmt alignment of theCommitstruct change. Wire format is unchanged.Comment-only change, so no test.
Evidence
Fixes #4
🤖 Generated with Claude Code