You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Choose the deploy arguments without relying on the CLI's release version #27
The action chooses the arguments for prisma deploy from the version of the installed prisma package (cli.mjs: takesEntryFlag, takesEnvironmentFlag). For example, it passes --environment to 8.0.0-rc.30 and later, and --stage before that.
A dev build of the CLI has the version of the last release plus -dev.N, for example 8.0.0-rc.34-dev.189. The rule ignores the -dev.N part. So when a deploy argument changes in a dev build, the action cannot tell that build from the unchanged release with the same base version.
Why it matters
prisma/prisma-cli#394 makes prisma-cli run this repository's tests/prisma-cli.test.mjs against every dev build it publishes. After an argument change, that check stays red, and alerts on every merge to prisma-cli's main, until the next CLI release has a version the action's rule can name. The action can only be fixed for the next release number, not for the dev builds that already have the change.
Options
Compare the -dev.N number as well. Dev build numbers only go up, so "rc.34-dev.200 or later" is a precise rule.
Ask the CLI what it accepts, for example by reading prisma deploy --help, and stop relying on the version.
Also
prisma-cli depends on two things here: the path tests/prisma-cli.test.mjs, and the PRISMA_CLI_BINS variable it reads. It also finds the deploy cases by their test titles. The README should say so, so that nobody renames them without changing prisma-cli's scripts/check-cloud-deploy-action.mjs.
Activity