fix(oak_session): disable TLS resumption with client auth - #5168
Open
secsson wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Thanks for this fix! Please run |
Author
Ran just format and pushed the resulting README change. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5167
Problem
OakSessionTlsContextretains one serverSSL_CTX, whileNewSession()resolves current trust anchors and attaches the custom verifier to each newSSL. A TLS 1.3 ticket created under an earlier client-authentication policy can therefore resume without a new client certificate check after the policy changes.This affects servers that keep a context alive while rotating client trust anchors or changing a stateful verifier decision. The supplied reproduction records that an old-ticket connection succeeds after revocation while the same client without the ticket is rejected. No production C++ consumer has been demonstrated.
Fix
Set
SSL_OP_NO_TICKETon each server-sideSSLwhenSSL_VERIFY_PEERis enabled. Applying the option per connection avoids mutating the shared context and leaves servers without client authentication unchanged.The README now makes the behavior explicit: C++ servers requiring client authentication perform a fresh authentication exchange for each new connection so current trust anchors and verifier policy are applied.
Tests
ClientAuthenticatedServerDoesNotIssueSessionTickets, which completes an mTLS handshake with a session-cache-capable client and counts outgoing server tickets.NewSessionTicketmessages.bazel test //oak_session/tls:oak_session_tls_test --test_output=errorspasses.git diff --checkpasses.Compatibility
There is no public API or framing change. Servers without client authentication retain their existing behavior. Client-authenticated C++ servers intentionally lose TLS session-resumption performance and require a fresh certificate exchange on reconnect so revocation and policy rotation take effect.