Skip to content

refactor: drop update info handling - #2644

Merged
winged merged 1 commit into
projectcaluma:mainfrom
winged:drop_update_info
Aug 25, 2026
Merged

refactor: drop update info handling#2644
winged merged 1 commit into
projectcaluma:mainfrom
winged:drop_update_info

Conversation

@winged

@winged winged commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

The previous version of the recalculation code needed the update info for deciding whether to update some table rows or not. This is now entirely obsolete and we don't need that information anymore. So we don't pass it along, and don't even collect it anymore.

@winged
winged requested a review from nlzet August 25, 2026 10:22

@nlzet nlzet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick added

Comment thread caluma/caluma_form/models.py Outdated
The previous version of the recalculation code needed the update info for
deciding whether to update some table rows or not. This is now entirely obsolete
and we don't need that information anymore. So we don't pass it along, and don't
even collect it anymore.
@winged winged changed the title chore: drop update info handling refactor: drop update info handling Aug 25, 2026

@nlzet nlzet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, LGTM 👍

@winged
winged merged commit 609e7b3 into projectcaluma:main Aug 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants