Repository navigation
Harden the deploy workflows against silent wrong-thing failures - #11
Merged
Merged
Conversation
- publish.yml: added run-name - publish.yml: added timeout-minutes to 2 job(s) - version.yml: dispatch input moved out of the shell line - version.yml: added run-name - version.yml: added timeout-minutes to 1 job(s) Part of the fleet sweep planned in igl-gotv docs/plans/workflow_hardening_sweep.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens the release/publish GitHub Actions workflows to reduce “silent wrong-thing” failures by improving run visibility and adding safety limits around long-running jobs.
Changes:
- Add human-readable
run-namevalues toversionandpublishworkflows. - Add
timeout-minutesto theversionrelease job and bothpublishjobs. - In
version.yml, pass the version throughenv:and quote it in the shell command instead of interpolating into therun:line.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CHANGELOG.md | Adds a release note describing the workflow hardening changes (needs correction re: concurrency). |
| .github/workflows/version.yml | Adds run-name, job timeout, and moves version input into an env var for safer npm version execution. |
| .github/workflows/publish.yml | Adds run-name and job timeouts for npm and GitHub Packages publishing jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| ### Changed | ||
|
|
||
| - Harden the deploy workflows: pass the version input through `env:` instead of interpolating it into the shell line; give the dispatch and tag workflows readable run titles; serialize deploys with a concurrency group and give every job a timeout. |
- corrected the CHANGELOG bullet Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Acted on the review:
Not taken, with reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet sweep from the plan in igl-gotv docs/plans/workflow_hardening_sweep.md, which carries the evidence for each change.
What changed here:
CHANGELOG updated.
Warning
version.yml,promote.yml,publish.ymlandredeploy.ymlare tag- or dispatch-triggered, so PR CI never exercises them. A green check here does not cover them - they were validated by parsing the YAML.