Skip to content

fix typo on calcparams_desoto help - #2174

Merged
kandersolar merged 2 commits into
pvlib:mainfrom
EduardoSarquis:fix_typo_on_calcparams_desoto
Aug 22, 2024
Merged

fix typo on calcparams_desoto help#2174
kandersolar merged 2 commits into
pvlib:mainfrom
EduardoSarquis:fix_typo_on_calcparams_desoto

Conversation

@EduardoSarquis

@EduardoSarquis EduardoSarquis commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

There's a typo in the documentation of the "saturation_current" parameter on line 1553.

  • Closes Typo at pvlib.pvsystem.calcparams_desoto #2163
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

As part of the PVLib workshop at the PVPMC Workshop on Copenhagen, I learned how to contribute to PVLib with an simple example of fixing a typo.

There's a typo in the documentation of the "saturation_current" parameter on line 1553.
@EduardoSarquis

Copy link
Copy Markdown
Contributor Author

The contribution can be found here.

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EduardoSarquis !

@kandersolar
kandersolar merged commit e2b1d9b into pvlib:main Aug 22, 2024
@kandersolar kandersolar added this to the v0.11.1 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo at pvlib.pvsystem.calcparams_desoto

2 participants