Skip to content

Spelling fix on "/pvlib/clearsky.py" documentation - #2176

Merged
kandersolar merged 3 commits into
pvlib:mainfrom
cardenca:iss2159
Sep 3, 2024
Merged

Spelling fix on "/pvlib/clearsky.py" documentation#2176
kandersolar merged 3 commits into
pvlib:mainfrom
cardenca:iss2159

Conversation

@cardenca

@cardenca cardenca commented Aug 22, 2024

Copy link
Copy Markdown
Contributor
  • Closes Documentation typo #2159
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse cwhanse added this to the v0.11.1 milestone Aug 26, 2024
@kandersolar

Copy link
Copy Markdown
Member

@cardenca thanks for the PR! Can you push a new commit to this PR to add yourself to the list of contributors in the v0.11.1 file in https://github.com/pvlib/pvlib-python/tree/main/docs/sphinx/source/whatsnew?

@cardenca

cardenca commented Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

@kandersolar I'm sorry for the delay. I already pushed the changes! thanks.

@kandersolar

Copy link
Copy Markdown
Member

@cardenca it looks like you made the changes in a new PR (#2197) instead of updating this one. It is better to make all related changes in a single PR. Can you please redo the "what's new" edit in the branch for this PR (it is called iss2159), and close #2197?

Thank you!

@cardenca

cardenca commented Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

@kandersolar now I think I did it well, thank you for the correction!

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cardenca! Hopefully we see more PRs from you in the future :)

@kandersolar
kandersolar merged commit 524fa55 into pvlib:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation typo

3 participants