You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Two active documentation issues remain: the testing statement does not match the workflow triggers, and a missing blank line may cause incorrect reStructuredText rendering.
Updates contributor governance guidelines based on the Open Nowcasting Hackathon discussion and adds automated handling for inactive issues and pull requests.
Changes:
Revises contribution, branching, issue, pull request, and AI-assisted development guidance.
Adds owner and maintainer responsibilities, inactivity rules, and restoration policies.
Adds a scheduled actions/stale@v11 workflow for stale issues and pull requests.
Nit (4 votes): Clarify that feature-branch commits are tested only through eligible pull requests or broaden the workflow trigger. Nits (2, 1, and 1 vote): Add a blank line after the nested list, document the additional 21-day close period after items become stale, and change “contributors guides” to “contributor guides” or “contributors' guides.”
.github/workflows/stale.yml
Adds scheduled stale issue and pull-request management.
Moderate (1 vote): Add repo-token: ${{ secrets.GITHUB_TOKEN }} to the with block so actions/stale can process issues and pull requests.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
An active critical workflow configuration issue prevents the documented stale-and-close policy from running, and a minor documentation wording issue also remains.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The workflow lacks actions: write, which can prevent actions/stale@v11 from updating its saved checkpoint and cause later runs to reuse outdated progress through the backlog.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Grant Actions write permission for checkpoint updates
.github/workflows/stale.yml:18
Add actions: write to this permissions block so actions/stale@v11 can replace its saved processing checkpoint through the Actions cache API. Without it, checkpoint updates can fail, causing later runs to reuse outdated progress instead of reliably advancing through the backlog when the operation limit is reached.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The workflow grants a third-party action unnecessary actions: write permission, expanding the token’s potential impact beyond the required issue and pull-request permissions.
The reason will be displayed to describe this comment to others. Learn more.
Should there be a mention of what the responsibilities of the owners are? (compared to maintainers)
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update guidelines based on the open source governance discussion held at the Open Nowcasting Hackathon in Belgium.
This addresses issue #599.