Repository navigation
Add project-root PythonTA config discovery - #28
Conversation
Coverage Report for CI Build 39093891568Coverage increased (+0.5%) to 51.704%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
david-yz-liu
left a comment
There was a problem hiding this comment.
@PraneethS42 the functionality is good, but in terms of the Settings UI (open the settings window and search "PythonTA") I think there could be some improvement.
First, please ensure the new option is immediately above the existing "Config Path" option.
Second, if the new option is checked, is there a way to disable to "Config Path" option? I feel like there is in VS Code settings.
|
Implemented Changes:
I couldn't find a way to disable the config path setting, but as you know, when this new setting is enabled, Config Path gets ignored, so it works functionally. It seems VS Code does not support conditional when or enablement rules, so an extension cannot dynamically grey out another native setting. I found this info from a denied VS Code feature request: microsoft/vscode#167843. |
david-yz-liu
left a comment
There was a problem hiding this comment.
Great, thanks for the updates @PraneethS42!

Proposed Changes
This PR adds a new
python-ta.useProjectRootConfigboolean setting, which is enabled by default.When it is enabled, the extension searches the workspace root for .pylintrc, pylintrc, or pyproject.toml, following PythonTA’s existing priority order. Any discovered file is passed to PythonTA as its configuration. While enabled, the existing python-ta.configPath setting is ignored.
Adds 3 tests to verify this behaviour, along with README/Changelog updates.
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)