Skip to content

Save configured sdists with a standard filename #1430

Closed

Description

@LalatenduMohanty

Some supported source: configurations fail to download source, or save it under a name that later commands cannot find. This prevents the package from building.

Examples:

  • A hook-sdist resolver hook returns a tag archive URL ending in /v1.0. With no download hook, the download fails with InvalidSdistFilename.
  • pypi-download with download_kind: sdist saves pkg-v1.0.tar.gz. Later, find_sdist() searches for pkg-1.0.tar.gz and finds nothing.

Expected: Save the archive using the package name and resolved version, preserving .tar.gz or .zip. Both cases should work without a custom download hook. Add regression tests for both cases.

Observed on new-resolver-config at ff8d7683. Related: #1414 — review comment.

Activity

  1. LalatenduMohanty commented on Nov 2, 2026

    @LalatenduMohanty
    MemberAuthor

    We’re treating this as a blocker for merging #1414 into main. The fix and regression tests should land in new-resolver-config before that merge.

  2. added 2 commits that reference this issue on Nov 2, 2026
    9158ac2
    88da44f
  3. LalatenduMohanty commented on Nov 2, 2026

    @LalatenduMohanty
    MemberAuthor

    #1438 has merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions