Skip to content

gh-152674: Avoid quadratic behavior in xml.etree.ElementPath index predicates - #152676

Merged
encukou merged 5 commits into
python:mainfrom
encukou:adf1
Jul 28, 2026
Merged

gh-152674: Avoid quadratic behavior in xml.etree.ElementPath index predicates#152676
encukou merged 5 commits into
python:mainfrom
encukou:adf1

Conversation

@encukou

@encukou encukou commented Jun 30, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

DarkaMaul and others added 4 commits June 30, 2026 13:20
@DarkaMaul @encukou
Fix GHSA-55rc-7hww-hf4p
ce3d3cd
@DarkaMaul @encukou
Fix test
be31685
@encukou @picnixz
Only cache the element at the given index
9158932 
Co-Authored-By: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@encukou
Add blurb
553173a
@encukou encukou changed the title Avoid quadratic behavior in xml.etree.ElementPath index predicates gh-152674: Avoid quadratic behavior in xml.etree.ElementPath index predicates Jun 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 30, 2026
Open
@encukou
encukou requested a review from serhiy-storchaka June 30, 2026 12:28
serhiy-storchaka
serhiy-storchaka approved these changes Jun 30, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I wonder if we need to save the cache in context, like parent_map.

@encukou

encukou commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

I wonder if we need to save the cache in context, like parent_map.

We can share this one across the context, it's specific to the query (index and elem.tag).

@encukou
encukou merged commit 2ffab08 into python:main Jul 28, 2026
58 checks passed
@encukou
encukou deleted the adf1 branch July 28, 2026 11:36
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 28, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154810 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 28, 2026
@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154811 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 28, 2026
@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154812 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 28, 2026
@encukou encukou added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 28, 2026
@encukou encukou added the needs backport to 3.12 only security fixes label Jul 28, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154813 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jul 28, 2026
@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154814 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.10 only security fixes label Jul 28, 2026
@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154815 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou @serhiy-storchaka @DarkaMaul