gh-154431: Revert "gh-154431: Fix data race in sys.audithook (#154462)" - #154769
Merged
Conversation
)" This commit caused a refleak. This reverts commit 596cd5c.
encukou
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
July 27, 2026 12:25
Member
Author
|
The reverted commit caused a refleak, breaking a tier 1 buildbot; see e.g. https://buildbot.python.org/#/builders/1610/builds/3726 |
Member
Author
|
!buildbot CentOS9.NoGIL.Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit c96bdde 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F154769%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
hugovk
approved these changes
Jul 27, 2026
encukou
added
the
needs backport to 3.15
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-154774 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
encukou
added a commit
that referenced
this pull request
Jul 27, 2026
…GH-154462)" (GH-154769) (GH-154774) This reverts commit 596cd5c. This commit caused a refleak. (cherry picked from commit c7b9a13) Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 596cd5c.
This commit caused a refleak, breaking a tier 1 buildbot.
sys.addaudithook()lazily createsinterp->audit_hookswith no lock #154431